-
Notifications
You must be signed in to change notification settings - Fork 0
Use GitHub secrets for production deployment #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kasper/staging-app-per-pr
Are you sure you want to change the base?
Conversation
Co-authored-by: kasperpeulen <[email protected]>
Co-authored-by: kasperpeulen <[email protected]>
Co-authored-by: kasperpeulen <[email protected]>
|
@copilot Check the init script and the delpoyment.md file if those are all secrets that need to be set. |
Co-authored-by: kasperpeulen <[email protected]>
Reviewed deployment.md and init script. Added the missing secrets to production deployment in commit 29a5137: All secrets now configured:
Production now matches staging's secret management approach. |
|
@copilot Update the .md files to set gh secrets just like for staging. |
Co-authored-by: kasperpeulen <[email protected]>
Co-authored-by: kasperpeulen <[email protected]>
Updated all documentation files in commits eefc50e and bf1dae3. All secrets now use Updated files:
All secrets correctly use GitHub environment-specific secrets matching the workflow's |
Production deployment was not using GitHub secrets for runtime configuration, while staging deployment was. This creates inconsistency in secret management and makes production setup more manual.
Changes
Workflow Changes
flyctl secretsstep to production deployment that sets all required secrets from GitHub environment secrets:SESSION_SECRET- Required for session managementHONEYPOT_SECRET- Required for honeypot spam protectionSENTRY_DSN- For error monitoring (optional but recommended)RESEND_API_KEY- For email functionality (optional but recommended)if: ${{ env.FLY_API_TOKEN }}) to both secrets and deployment steps for consistency with staging patternDocumentation Changes
docs/deployment.mdto usegh secret set -e productionfor SESSION_SECRET and HONEYPOT_SECRET instead offly secrets setdocs/email.mdto usegh secret set -e productionfor RESEND_API_KEY instead offly secrets setdocs/monitoring.mdto usegh secret set -e productionfor SENTRY_DSN instead offly secrets setAll documentation now instructs users to set secrets via GitHub environment secrets using
-e productionfor production environment and-e stagingfor staging environment, matching the workflow'senvironment: productionconfiguration.Staging and production now follow the same secret management approach with all runtime secrets configured through GitHub Actions environment secrets.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.